-
Notifications
You must be signed in to change notification settings - Fork 1
Top bar improvements #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I like the saved space (current screenshot below, for 'before' see #10 ) & especially how the selected jar updates to match the page.
Pinging @finglis and @alanocallaghan for their thoughts. |
I also see it as a web browser, which is why I prefer it on the left + center... the big inviting space to type in. Generally I use the URL bar to search. But in that case, the search bar should be the one that fills as much extra width as is available - to make it the most prominent control. It also doesn't need 'Search' as a label - since URL bars don't say this - and instead the prompt text of the text field could be used. My thinking is less about right and left, but more about nudging the user into paying attention to the control that they are most likely to want to use... and I think searching will be more common than selecting a jar. But if the combo box needs to be as wide as it currently is, then I agree that the search bar looks better on the right... because placing it on the left, but narrow, creates a confusing message about which one the user should focus on. So from your two screenshots, I do prefer the second one. I'm ok if the consensus is that we stick with it.
If you can decrease the width of the window, I'd expect the toolbar to behave differently when the components don't all fit. |
|
The viewer in the last screenshot was implemented in the last commit. |
|
Thanks, looks good, let's merge! |




Address #10 by: